Files
meshtastic-web/apps/web/src/components/Dialog/DialogWrapper.tsx
T
Ben MeadorsandGitHub bbe9a0d5cd feat(protobufs): sync to firmware-current and consume workspace package (#1097)
* feat(protobufs): sync to firmware-current and consume workspace package

Sync the vendored .proto sources to firmware-current (v2.7.25+48), regenerate the v2 TS bindings, and consume the workspace @meshtastic/protobufs (workspace:*) in place of the stale JSR 2.7.20 — finishing the monorepo migration (core was already workspace:*).

Includes the one required breaking-change fix: admin nodedb_reset changed int32 to bool, so resetNodes() now sends value: true.

* build(protobufs): vendor generated bindings for workspace consumers

The package is consumed via workspace:* — its exports point at the TS source, which imports ./dist/meshtastic/*_pb.ts — so the generated output must exist at build time. CI builds web/core with no codegen step and the runners have no buf CLI, so the bindings are vendored here (kept gitignored; lint/format skip them). Regenerate with: pnpm --filter @meshtastic/protobufs gen

* fix(protobufs): clean script removes the actual generated output dir

buf writes bindings to packages/ts/dist, but clean was removing a non-existent root dist — so it never cleaned stale output. Addresses Copilot review feedback.

* refactor: move web app packages/web -> apps/web

Aligns the web app with the apps/web layout (matching the Vercel web-test Root Directory and the SDK-migration direction). Pure directory move plus root config: pnpm-workspace (adds apps/*), vitest projects, root tsconfig reference, and the pr/release-web/nightly workflows. vercel.json moved with the app. Build + 36 validation tests green.

* feat: config fields, module pages, key verification, telemetry capture

Incorporates the firmware-current feature work onto the protobuf foundation: new config fields (Display message bubbles; LoRa fem_lna_mode + serial_hal_only; Telemetry air_quality_screen_enabled); 4 new ModuleConfig pages (TrafficManagement, StatusMessage, TAK, RemoteHardware); the manual Key Verification flow (sendKeyVerification + ClientNotificationDialog stages + Verify Key button); live telemetry capture (nodeDB addDeviceMetrics) and admin hardening (toggleMutedNode, graceful PortNum default); plus the sdk-preview ConfigEditor demo and store/config tests. Build + lint + format + 131 tests green.

* chore: drop #1062 (unsaved-change-detection) to match upstream revert

#1062 was merged to main by accident (per @danditomaso) and is being reverted. Reverse-applied its diff here via 3-way so #1097 stays consistent with where main is headed, while keeping the feature changes layered on the same files (deviceStore/changeRegistry). Build + 131 tests + lint + format green.

* fix(nodes): clean up SNR display in node table and map popup

SNR is a ratio measured in dB, not dBm (which is absolute power); the
node table and map popup both mislabeled it and crammed three values
together: '0dBm/50%/50raw'. The trailing '%/raw' pair was the same
heuristic ((snr+10)*5) shown twice — once clamped, once not.

Render SNR in dB rounded to one decimal, color-coded by a 0-100%
signal-quality heuristic (green/yellow/red), with the quality percentage
as a muted secondary. Drop the redundant raw value. Adds unit.db; this
matches the existing SNRTooltip, which already renders dB.
2026-06-15 13:23:28 -05:00

142 lines
3.1 KiB
TypeScript

import { Button } from "@components/UI/Button.tsx";
import {
Dialog,
DialogClose,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from "@components/UI/Dialog.tsx";
import { Separator } from "@components/UI/Separator.tsx";
import type { ReactNode } from "react";
import { useTranslation } from "react-i18next";
export type DialogVariant = "default" | "destructive";
export type DialogType = "confirm" | "alert" | "info" | "custom";
export interface DialogWrapperProps {
open: boolean;
onOpenChange: (open: boolean) => void;
title: string;
description?: string;
type?: DialogType;
icon?: ReactNode;
children?: ReactNode;
showFooter?: boolean;
confirmText?: string;
cancelText?: string;
dismissText?: string;
variant?: DialogVariant;
confirmIcon?: ReactNode;
customFooter?: ReactNode;
onConfirm?: () => void | Promise<void>;
onCancel?: () => void;
onDismiss?: () => void;
}
export const DialogWrapper = ({
open,
onOpenChange,
title,
description,
type = "custom",
icon,
children,
showFooter = true,
confirmText,
cancelText,
dismissText,
variant = "default",
confirmIcon,
customFooter,
onConfirm,
onCancel,
onDismiss,
}: DialogWrapperProps) => {
const { t } = useTranslation("dialog");
const handleClose = () => {
onOpenChange(false);
};
const handleConfirm = async () => {
if (onConfirm) {
await onConfirm();
}
handleClose();
};
const handleCancel = () => {
if (onCancel) {
onCancel();
}
handleClose();
};
const handleDismiss = () => {
if (onDismiss) {
onDismiss();
}
handleClose();
};
const renderFooter = () => {
if (!showFooter) {
return null;
}
if (customFooter) {
return <DialogFooter className="mt-4">{customFooter}</DialogFooter>;
}
switch (type) {
case "confirm":
return (
<DialogFooter className="mt-4">
<Button variant="outline" onClick={handleCancel} name="cancel">
{cancelText || t("button.cancel")}
</Button>
<Button variant={variant} onClick={handleConfirm} name="confirm">
{confirmIcon && <span className="mr-2">{confirmIcon}</span>}
{confirmText || t("button.confirm")}
</Button>
</DialogFooter>
);
case "alert":
case "info":
return (
<DialogFooter className="mt-4">
<Button variant="outline" onClick={handleDismiss} name="dismiss">
{dismissText || t("button.dismiss")}
</Button>
</DialogFooter>
);
default:
return null;
}
};
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent>
<DialogClose />
<DialogHeader>
<DialogTitle className="flex items-center gap-2">
{icon && icon}
{title}
</DialogTitle>
{type !== "custom" && <Separator />}
{description && <DialogDescription>{description}</DialogDescription>}
</DialogHeader>
{children}
{renderFooter()}
</DialogContent>
</Dialog>
);
};