Overhaul (#83)

* WIP Layout Refactor

* New Connection Dialog

* WIP form overhaul

* Fix remaining config pages

src/components/PageComponents/ModuleConfig/Serial.tsx

@@ -1,28 +1,12 @@
-import { useEffect } from "react";
-import { Controller, useForm, useWatch } from "react-hook-form";
-import { Input } from "@components/form/Input.js";
-import { Toggle } from "@components/form/Toggle.js";
-import { SerialValidation } from "@app/validation/moduleConfig/serial.js";
-import { Form } from "@components/form/Form";
-import { useDevice } from "@core/providers/useDevice.js";
-import { classValidatorResolver } from "@hookform/resolvers/class-validator";
+import type { SerialValidation } from "@app/validation/moduleConfig/serial.js";
+import { useDevice } from "@core/stores/deviceStore.js";
 import { Protobuf } from "@meshtastic/meshtasticjs";
-import { renderOptions } from "@core/utils/selectEnumOptions";
-import { Select } from "@components/form/Select";
+import { DynamicForm } from "@app/components/DynamicForm.js";
 
 export const Serial = (): JSX.Element => {
   const { moduleConfig, setWorkingModuleConfig } = useDevice();
-  const { register, handleSubmit, reset, control } = useForm<SerialValidation>({
-    mode: "onChange",
-    defaultValues: moduleConfig.serial,
-    resolver: classValidatorResolver(SerialValidation)
-  });
 
-  useEffect(() => {
-    reset(moduleConfig.serial);
-  }, [reset, moduleConfig.serial]);
-
-  const onSubmit = handleSubmit((data) => {
+  const onSubmit = (data: SerialValidation) => {
     setWorkingModuleConfig(
       new Protobuf.ModuleConfig({
         payloadVariant: {
@@ -31,84 +15,98 @@ export const Serial = (): JSX.Element => {
         }
       })
     );
-  });
-
-  const moduleEnabled = useWatch({
-    control,
-    name: "enabled",
-    defaultValue: false
-  });
+  };
 
   return (
-    <Form onSubmit={onSubmit}>
-      <Controller
-        name="enabled"
-        control={control}
-        render={({ field: { value, ...rest } }) => (
-          <Toggle
-            label="Module Enabled"
-            description="Enable Serial output"
-            checked={value}
-            {...rest}
-          />
-        )}
-      />
-      <Controller
-        name="echo"
-        control={control}
-        render={({ field: { value, ...rest } }) => (
-          <Toggle
-            label="Echo"
-            description="Any packets you send will be echoed back to your device"
-            checked={value}
-            {...rest}
-          />
-        )}
-      />
-      <Input
-        type="number"
-        label="RX Pin"
-        description="Set the GPIO pin to the RXD pin you have set up."
-        disabled={!moduleEnabled}
-        {...register("rxd", {
-          valueAsNumber: true
-        })}
-      />
-      <Input
-        type="number"
-        label="TX Pin"
-        description="Set the GPIO pin to the TXD pin you have set up."
-        disabled={!moduleEnabled}
-        {...register("txd", {
-          valueAsNumber: true
-        })}
-      />
-      <Select
-        label="Baud Rate"
-        description="The serial baud rate"
-        disabled={!moduleEnabled}
-        {...register("baud", { valueAsNumber: true })}
-      >
-        {renderOptions(Protobuf.ModuleConfig_SerialConfig_Serial_Baud)}
-      </Select>
-      <Input
-        type="number"
-        label="Timeout"
-        suffix="Seconds"
-        description="Seconds to wait before we consider your packet as 'done'"
-        disabled={!moduleEnabled}
-        {...register("timeout", {
-          valueAsNumber: true
-        })}
-      />
-      <Select
-        label="Mode"
-        description="Select Mode"
-        disabled={!moduleEnabled}
-        {...register("mode", { valueAsNumber: true })}
-      >
-        {renderOptions(Protobuf.ModuleConfig_SerialConfig_Serial_Mode)}
-      </Select>
-    </Form>
+    <DynamicForm<SerialValidation>
+      onSubmit={onSubmit}
+      defaultValues={moduleConfig.serial}
+      fieldGroups={[
+        {
+          label: "Serial Settings",
+          description: "Settings for the Serial module",
+          fields: [
+            {
+              type: "toggle",
+              name: "enabled",
+              label: "Module Enabled",
+              description: "Enable Serial output"
+            },
+            {
+              type: "toggle",
+              name: "echo",
+              label: "Echo",
+              description:
+                "Any packets you send will be echoed back to your device",
+              disabledBy: [
+                {
+                  fieldName: "enabled"
+                }
+              ]
+            },
+            {
+              type: "number",
+              name: "rxd",
+              label: "Receive Pin",
+              description: "Set the GPIO pin to the RXD pin you have set up.",
+              disabledBy: [
+                {
+                  fieldName: "enabled"
+                }
+              ]
+            },
+            {
+              type: "number",
+              name: "txd",
+              label: "Transmit Pin",
+              description: "Set the GPIO pin to the TXD pin you have set up.",
+              disabledBy: [
+                {
+                  fieldName: "enabled"
+                }
+              ]
+            },
+            {
+              type: "select",
+              name: "baud",
+              label: "Baud Rate",
+              description: "The serial baud rate",
+              enumValue: Protobuf.ModuleConfig_SerialConfig_Serial_Baud,
+              disabledBy: [
+                {
+                  fieldName: "enabled"
+                }
+              ]
+            },
+            {
+              type: "number",
+              name: "timeout",
+              label: "Timeout",
+              suffix: "Seconds",
+              description:
+                "Seconds to wait before we consider your packet as 'done'",
+              disabledBy: [
+                {
+                  fieldName: "enabled"
+                }
+              ]
+            },
+            {
+              type: "select",
+              name: "mode",
+              label: "Mode",
+              description: "Select Mode",
+              enumValue: Protobuf.ModuleConfig_SerialConfig_Serial_Mode,
+              formatEnumName: true,
+              disabledBy: [
+                {
+                  fieldName: "enabled"
+                }
+              ]
+            }
+          ]
+        }
+      ]}
+    />
   );
 };