Address new linting rules (#851)

Co-authored-by: philon- <philon-@users.noreply.github.com>
This commit is contained in:
Jeremy Gallant
2025-09-14 21:31:47 -04:00
committed by GitHub
co-authored by philon-
parent 37ad0ac9eb
commit aaf85943a8
16 changed files with 27 additions and 32 deletions
@@ -84,7 +84,7 @@ export const ImportDialog = ({ open, onOpenChange }: ImportDialogProps) => {
}, [importDialogInput, t]);
const apply = () => {
channelSet?.settings.map(
channelSet?.settings.forEach(
(ch: Protobuf.Channel.ChannelSettings, index: number) => {
if (importIndex[index] === -1) {
return;
@@ -140,7 +140,7 @@ export const ImportDialog = ({ open, onOpenChange }: ImportDialogProps) => {
const onSelectChange = (value: string, index: number) => {
const newImportIndex = [...importIndex];
newImportIndex[index] = Number.parseInt(value);
newImportIndex[index] = Number.parseInt(value, 10);
setImportIndex(newImportIndex);
};
@@ -43,7 +43,6 @@ export const ManagedModeDialog = ({
</DialogHeader>
<div className="flex items-center gap-2">
<Checkbox
id="managedMode"
checked={confirmState}
onChange={() => setConfirmState(!confirmState)}
name="confirmUnderstanding"
@@ -37,7 +37,7 @@ export const ShutdownDialog = ({ open, onOpenChange }: ShutdownDialogProps) => {
<Input
type="number"
value={time}
onChange={(e) => setTime(Number.parseInt(e.target.value))}
onChange={(e) => setTime(Number.parseInt(e.target.value, 10))}
suffix={t("unit.minute.plural")}
/>
<Button className="w-24" onClick={handleScheduledShutdown}>
@@ -59,7 +59,6 @@ export const UnsafeRolesDialog = ({
</DialogDescription>
<div className="flex items-center gap-2">
<Checkbox
id="routerRole"
checked={confirmState}
onChange={() => setConfirmState(!confirmState)}
name="confirmUnderstanding"
@@ -84,7 +84,7 @@ export function SelectInput<T extends FieldValues>({
if (field.selectChange) {
field.selectChange(newValue, selectedKey);
}
onChange(Number.parseInt(newValue));
onChange(Number.parseInt(newValue, 10));
};
return (
@@ -148,7 +148,7 @@ export const Channel = ({ onFormInit, channel }: SettingsPanelProps) => {
};
const selectChangeEvent = (e: string) => {
const count = Number.parseInt(e);
const count = Number.parseInt(e, 10);
if (!Number.isNaN(count)) {
setBytes(count);
trigger("settings.psk");
@@ -60,7 +60,6 @@ export default function ThemeSwitcher({
<Button
variant="ghost"
onClick={toggleTheme}
id="theme-switcher"
aria-label={t("theme.changeTheme")}
className={cn(
"group relative flex justify-start",
@@ -75,6 +75,7 @@ describe("Checkbox", () => {
});
it("uses provided id", () => {
// biome-ignore lint/correctness/useUniqueElementIds: <test>
render(<Checkbox id="custom-id" />);
expect(screen.getByRole("checkbox").id).toBe("custom-id");
});
+2 -8
View File
@@ -72,10 +72,7 @@ export function ErrorPage({ error }: { error: Error }) {
<label htmlFor="message">
{t("errorPage.errorMessageLabel")}
</label>
<p
id="message"
className="text-slate-400 break-words overflow-wrap"
>
<p className="text-slate-400 break-words overflow-wrap">
{error.message}
</p>
</> // TODO: Use Trans for the label and message together?
@@ -83,10 +80,7 @@ export function ErrorPage({ error }: { error: Error }) {
{error?.stack && (
<>
<label htmlFor="stack">{t("errorPage.stackTraceLabel")}</label>
<p
id="stack"
className="text-slate-400 break-words overflow-wrap"
>
<p className="text-slate-400 break-words overflow-wrap">
{error.stack}
</p>
</>
@@ -244,7 +244,6 @@ export function FilterControl({
</label>
<Input
type="text"
id="nodeName"
value={filterState.nodeName}
onChange={handleTextChange("nodeName")}
showClearButton