hermes/meshtastic-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #538 from danditomaso/issue-537-position-flags-undefined

Browse Source 
fix: ensured undefined position flags are handled
This commit is contained in:
Dan Ditomaso
2025-03-26 13:08:55 -04:00
committed by GitHub
parent dcbfb08f26 488fd61558
commit a378cce0be
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/PageComponents/Config/Position.tsx
+4 -4
View File
@@ -1,8 +1,8 @@
import { import {
type FlagName, type FlagName,
usePositionFlags, usePositionFlags,
} from "../../../core/hooks/usePositionFlags.ts"; } from "@core/hooks/usePositionFlags.ts";
import type { PositionValidation } from "@app/validation/config/position.tsx"; import type { PositionValidation } from "@app/validation/config/position.ts";
import { create } from "@bufbuild/protobuf"; import { create } from "@bufbuild/protobuf";
import { DynamicForm } from "@components/Form/DynamicForm.tsx"; import { DynamicForm } from "@components/Form/DynamicForm.tsx";
import { useDevice } from "@core/stores/deviceStore.ts"; import { useDevice } from "@core/stores/deviceStore.ts";
@@ -12,7 +12,7 @@ import { useCallback } from "react";
export const Position = () => { export const Position = () => {
const { config, setWorkingConfig } = useDevice(); const { config, setWorkingConfig } = useDevice();
const { flagsValue, activeFlags, toggleFlag, getAllFlags } = usePositionFlags( const { flagsValue, activeFlags, toggleFlag, getAllFlags } = usePositionFlags(
config?.position.positionFlags ?? 0, config?.position?.positionFlags ?? 0,
); );
const onSubmit = (data: PositionValidation) => { const onSubmit = (data: PositionValidation) => {
@@ -74,7 +74,7 @@ export const Position = () => {
name: "positionFlags", name: "positionFlags",
value: activeFlags, value: activeFlags,
isChecked: (name: string) => isChecked: (name: string) =>
activeFlags.includes(name as FlagName), activeFlags?.includes(name as FlagName) ?? false,
onValueChange: onPositonFlagChange, onValueChange: onPositonFlagChange,
label: "Position Flags", label: "Position Flags",
placeholder: "Select position flags...", placeholder: "Select position flags...",