hermes/meshtastic-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix node mapping and unknown node display in traceroute dialogs (#728)

Browse Source 
Corrects the mapping of 'from' and 'to' nodes in TracerouteResponseDialog to reflect the actual origin and destination of traceroute packets. Also updates TraceRoute to display a localized unknown name for node ID 4294967295 (0xffffff), improving clarity for unknown nodes.
This commit is contained in:
Jeremy Gallant
2025-07-23 21:31:05 -04:00
committed by GitHub
parent bbb43de87b
commit 5b417a321a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/web/src/components/Dialog/TracerouteResponseDialog.tsx
+2 -2
View File
@@ -30,7 +30,7 @@ export const TracerouteResponseDialog = ({
const routeBack: number[] = traceroute?.data.routeBack ?? []; const routeBack: number[] = traceroute?.data.routeBack ?? [];
const snrTowards = (traceroute?.data.snrTowards ?? []).map((snr) => snr / 4); const snrTowards = (traceroute?.data.snrTowards ?? []).map((snr) => snr / 4);
const snrBack = (traceroute?.data.snrBack ?? []).map((snr) => snr / 4); const snrBack = (traceroute?.data.snrBack ?? []).map((snr) => snr / 4);
const from = getNode(traceroute?.from ?? 0); const from = getNode(traceroute?.to ?? 0); // The origin of the traceroute = the "to" node of the mesh packet
const fromLongName = const fromLongName =
from?.user?.longName ?? from?.user?.longName ??
(from ? `!${numberToHexUnpadded(from?.num)}` : t("unknown.shortName")); (from ? `!${numberToHexUnpadded(from?.num)}` : t("unknown.shortName"));
@@ -40,7 +40,7 @@ export const TracerouteResponseDialog = ({
? `${numberToHexUnpadded(from?.num).substring(0, 4)}` ? `${numberToHexUnpadded(from?.num).substring(0, 4)}`
: t("unknown.shortName")); : t("unknown.shortName"));
const toUser = getNode(traceroute?.to ?? 0); const toUser = getNode(traceroute?.from ?? 0); // The destination of the traceroute = the "from" node of the mesh packet
if (!toUser || !from) { if (!toUser || !from) {
return null; return null;
packages/web/src/components/PageComponents/Messages/TraceRoute.tsx
+1 -1
View File
@@ -41,7 +41,7 @@ const RoutePath = ({ title, from, to, path, snr }: RoutePathProps) => {
<span key={getNode(hop)?.num ?? hop}> <span key={getNode(hop)?.num ?? hop}>
<p> <p>
{getNode(hop)?.user?.longName ?? {getNode(hop)?.user?.longName ??
`${t("traceRoute.nodeUnknownPrefix")}${numberToHexUnpadded(hop)}`} `${t("unknown.longName")} (!${numberToHexUnpadded(hop)})`}
</p> </p>
<p> <p>
↓ {snr?.[i + 1] ?? t("unknown.num")} ↓ {snr?.[i + 1] ?? t("unknown.num")}