hermes/meshtastic-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove useEffect

Browse Source
This commit is contained in:
Tilen Komel
2025-02-04 21:50:11 +01:00
parent 44b8dd308a
commit 5a1c207ffc
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/Dialog/NodeDetailsDialog.tsx
+1 -7
View File
@@ -15,7 +15,6 @@ import {
} from "@components/UI/Dialog"; } from "@components/UI/Dialog";
import { Protobuf } from "@meshtastic/js"; import { Protobuf } from "@meshtastic/js";
import { numberToHexUnpadded } from "@noble/curves/abstract/utils"; import { numberToHexUnpadded } from "@noble/curves/abstract/utils";
import { useEffect, useState } from "react";
import { DeviceImage } from "../generic/DeviceImage"; import { DeviceImage } from "../generic/DeviceImage";
import { TimeAgo } from "../generic/TimeAgo"; import { TimeAgo } from "../generic/TimeAgo";
import { Uptime } from "../generic/Uptime"; import { Uptime } from "../generic/Uptime";
@@ -31,12 +30,7 @@ export const NodeDetailsDialog = ({
}: NodeDetailsDialogProps) => { }: NodeDetailsDialogProps) => {
const { nodes } = useDevice(); const { nodes } = useDevice();
const { nodeNumDetails } = useAppStore(); const { nodeNumDetails } = useAppStore();
const [device, setDevice] = useState<Protobuf.Mesh.NodeInfo | null>(null); const device: Protobuf.Mesh.NodeInfo = nodes.get(nodeNumDetails);
useEffect(() => {
if (!nodeNumDetails) return;
setDevice(nodes.get(nodeNumDetails));
}, [nodeNumDetails, nodes]);
return device ? ( return device ? (
<Dialog open={open} onOpenChange={onOpenChange}> <Dialog open={open} onOpenChange={onOpenChange}>