From 38c7569d0f91d505d394f4497449a292b6cad72b Mon Sep 17 00:00:00 2001
From: Hunter Thornsberry <hunter@hunterthornsberry.com>
Date: Fri, 10 Jul 2026 21:10:39 -0400
Subject: [PATCH] Fix blank error message when using Serial on Firefox (#1254)

* add checks for both bluetooth and serial in the FeatureErrorMessage logic

* move the check further down and only show if neither needsSecureContext and needsFeature are empty

---------

Co-authored-by: Hunter275 <hunterthor275@gmail.com>
---
 .../Dialog/AddConnectionDialog/AddConnectionDialog.tsx        | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/apps/web/src/components/Dialog/AddConnectionDialog/AddConnectionDialog.tsx b/apps/web/src/components/Dialog/AddConnectionDialog/AddConnectionDialog.tsx
index 38332c7f..f8c21a68 100644
--- a/apps/web/src/components/Dialog/AddConnectionDialog/AddConnectionDialog.tsx
+++ b/apps/web/src/components/Dialog/AddConnectionDialog/AddConnectionDialog.tsx
@@ -115,6 +115,10 @@ const FeatureErrorMessage = ({ missingFeatures, tabId }: FeatureErrorProps) => {
         ? "Web Serial"
         : undefined;
 
+  if (!needsFeature && !needsSecureContext) {
+    return null;
+  }
+
   return (
     <div className="flex flex-col items-start gap-2 bg-red-500 p-4 rounded-md text-sm mt-4">
       <div className="flex items-center gap-2 w-full">