refactor-ota-dialog (#768)

Co-authored-by: philon- <philon-@users.noreply.github.com>
2025-08-10 07:49:42 -04:00
parent 27ed4e58bd
commit 1dbf0b07b6
11 changed files with 202 additions and 190 deletions
@@ -0,0 +1,175 @@
+import { fireEvent, render, screen, waitFor } from "@testing-library/react";
+import type {
+  ButtonHTMLAttributes,
+  ClassAttributes,
+  InputHTMLAttributes,
+  ReactNode,
+} from "react";
+import type { JSX } from "react/jsx-runtime";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { RebootDialog } from "./RebootDialog.tsx";
+
+const rebootMock = vi.fn();
+const rebootOtaMock = vi.fn();
+let mockConnection: { 
+  rebootOta: (delay: number) => void,
+  reboot: (delay: number) => void
+ } | undefined = {
+  reboot: rebootMock,
+  rebootOta: rebootOtaMock,
+};
+
+vi.mock("@core/stores/deviceStore.ts", () => ({
+  useDevice: () => ({
+    connection: mockConnection,
+  }),
+}));
+
+vi.mock("@components/UI/Button.tsx", async () => {
+  const actual = await vi.importActual("@components/UI/Button.tsx");
+  return {
+    ...actual,
+    Button: (
+      props: JSX.IntrinsicAttributes &
+        ClassAttributes<HTMLButtonElement> &
+        ButtonHTMLAttributes<HTMLButtonElement>,
+    ) => <button {...props} />,
+  };
+});
+
+vi.mock("@components/UI/Input.tsx", async () => {
+  const actual = await vi.importActual("@components/UI/Input.tsx");
+  return {
+    ...actual,
+    Input: (
+      props: JSX.IntrinsicAttributes &
+        ClassAttributes<HTMLInputElement> &
+        InputHTMLAttributes<HTMLInputElement>,
+    ) => <input {...props} />,
+  };
+});
+
+vi.mock("@components/UI/Dialog.tsx", () => {
+  return {
+    Dialog: ({ children }: { children: ReactNode }) => <div>{children}</div>,
+    DialogContent: ({ children }: { children: ReactNode }) => (
+      <div>{children}</div>
+    ),
+    DialogHeader: ({ children }: { children: ReactNode }) => (
+      <div>{children}</div>
+    ),
+    DialogTitle: ({ children }: { children: ReactNode }) => <h1>{children}</h1>,
+    DialogDescription: ({ children }: { children: ReactNode }) => (
+      <p>{children}</p>
+    ),
+    DialogClose: () => null,
+  };
+});
+
+describe("RebootDialog", () => {
+  beforeEach(() => {
+    vi.useFakeTimers();
+    rebootOtaMock.mockClear();
+  });
+
+  afterEach(() => {
+    vi.useRealTimers();
+  });
+
+  it("renders dialog with default input value", () => {
+    render(<RebootDialog open onOpenChange={() => {}} />);
+    expect(screen.getByPlaceholderText(/enter delay/i)).toHaveValue(5);
+    expect(
+      screen.getByRole("heading", { name: /reboot device/i, level: 1 }),
+    ).toBeInTheDocument();
+    expect(screen.getByRole("button", { name: /reboot now/i })).toBeInTheDocument();
+  });
+
+    it("calls correct reboot function based on OTA checkbox state", () => {
+      render(<RebootDialog open onOpenChange={() => {}} />);
+
+      // Schedule non-OTA reboot
+      fireEvent.click(screen.getByTestId("scheduleRebootBtn"));
+      expect(rebootMock).toHaveBeenCalledWith(5);
+      expect(rebootOtaMock).not.toHaveBeenCalled();
+
+      rebootMock.mockClear();
+      rebootOtaMock.mockClear();
+
+      // Cancel scheduled
+      fireEvent.click(screen.getByTestId("cancelRebootBtn"));
+      expect(rebootMock).toHaveBeenCalledWith(-1);
+      expect(rebootOtaMock).not.toHaveBeenCalled();
+
+      rebootMock.mockClear();
+      rebootOtaMock.mockClear();
+
+      // Schedule OTA reboot
+      fireEvent.click(screen.getByText(/reboot into ota mode/i));
+      fireEvent.click(screen.getByTestId("scheduleRebootBtn"));
+      expect(rebootOtaMock).toHaveBeenCalledWith(5);
+      expect(rebootMock).not.toHaveBeenCalled();
+    });
+
+  it("schedules a reboot with delay and calls rebootOta", async () => {
+    const onOpenChangeMock = vi.fn();
+    render(<RebootDialog open onOpenChange={onOpenChangeMock} />);
+
+    fireEvent.change(screen.getByPlaceholderText(/enter delay/i), {
+      target: { value: "3" },
+    });
+
+    fireEvent.click(screen.getByTestId("scheduleRebootBtn"));
+    
+    expect(rebootMock).toHaveBeenCalledWith(3);
+
+    expect(screen.getByText(/reboot has been scheduled/i)).toBeInTheDocument();
+
+    vi.advanceTimersByTime(3000);
+
+    expect(onOpenChangeMock).toHaveBeenCalledWith(false);
+
+  });
+
+  it("triggers an instant reboot", async () => {
+    const onOpenChangeMock = vi.fn();
+    render(<RebootDialog open onOpenChange={onOpenChangeMock} />);
+
+    fireEvent.click(screen.getByRole("button", { name: /reboot now/i }));
+
+    expect(rebootMock).toHaveBeenCalledWith(0);
+    expect(onOpenChangeMock).toHaveBeenCalledWith(false);
+  });
+
+  it("does not call reboot if connection is undefined", async () => {
+    const onOpenChangeMock = vi.fn();
+
+    mockConnection = undefined;
+
+    render(<RebootDialog open onOpenChange={onOpenChangeMock} />);
+
+    fireEvent.click(screen.getByTestId("scheduleRebootBtn"));
+
+    vi.advanceTimersByTime(5000);
+
+    expect(rebootMock).not.toHaveBeenCalled();
+    expect(rebootOtaMock).not.toHaveBeenCalled();
+
+    mockConnection = { reboot: rebootMock, rebootOta: rebootOtaMock };
+  });
+
+  it("cancels a scheduled reboot and calls rebootOta with -1", async () => {
+    const onOpenChangeMock = vi.fn();
+    render(<RebootDialog open onOpenChange={onOpenChangeMock} />);
+
+    fireEvent.change(screen.getByPlaceholderText(/enter delay/i), {
+      target: { value: "4" },
+    });
+    fireEvent.click(screen.getByTestId("scheduleRebootBtn"));
+    expect(rebootMock).toHaveBeenCalledWith(4);
+
+    fireEvent.click(screen.getByRole("button", { name: /cancel/i }));
+    expect(rebootMock).toHaveBeenCalledWith(-1);
+    expect(screen.queryByText(/reboot has been scheduled/i)).not.toBeInTheDocument();
+  });
+});